Hi Ben,

On Tue, Nov 11, 2014 at 03:09:42PM +0000, Ben Hutchings wrote:
> > >From 4d91c83577a4dbe8c52271bbd157b450b8c7edf3 Mon Sep 17 00:00:00 2001
> > From: Michael Weiser <m.wei...@science-computing.de>
> > Date: Fri, 31 Oct 2014 11:36:10 +0100
> > Subject: [PATCH] Allow for devices such as /dev/sdaa
> Based on a quick survey of block drivers:

> 'sd', 'rssd' and 'vd' may be followed by multiple letters
> 'dasd' may be followed by up to 4 letters
> 'scm' or 'xvd' may be followed by up to 2 letters

> Please don't just fix the 'sd' 2-letter case!

Okay. New patch attached that should catch /dev/sdxy*, /dev/vdxy* and
/dev/xvdx*. Can't find any place where grub-installer treats rssd, dasd
or scm.

> > -    
> > /dev/[hsv]d[a-z0-9]|/dev/xvd[a-z]|/dev/cciss/c[0-9]d[0-9]*|/dev/ida/c[0-9]d[0-9]*|/dev/rs/c[0-9]d[0-9]*|/dev/mmcblk[0-9]|/dev/ad[0-9]*|/dev/da[0-9]*)
> > +    
> > /dev/[hsv]d[a-z0-9][a-z0-9]|/dev/xvd[a-z]|/dev/cciss/c[0-9]d[0-9]*|/dev/ida/c[0-9]d[0-9]*|/dev/rs/c[0-9]d[0-9]*|/dev/mmcblk[0-9]|/dev/ad[0-9]*|/dev/da[0-9]*)
> >     disc_offered_devfs="$prefix"
This was wrong: Didn't catch /dev/sda anymore. Understood now that it
only worked because I was actually installing grub on /dev/sdaa.

Regards.
-- 
Michael Weiser                science + computing ag
Senior Systems Engineer       Geschaeftsstelle Duesseldorf
                              Faehrstrasse 1
phone: +49 211 302 708 32     D-40221 Duesseldorf
fax:   +49 211 302 708 50     www.science-computing.de
-- 
Vorstandsvorsitzender/Chairman of the board of management:
Gerd-Lothar Leonhart
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Michael Heinrichs, Dr. Arno Steitz
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Philippe Miltin
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196
>From 333151e5eed04e7ef292bb15109131e731092674 Mon Sep 17 00:00:00 2001
From: Michael Weiser <m.wei...@science-computing.de>
Date: Tue, 11 Nov 2014 16:59:05 +0100
Subject: [PATCH] Allow for devices with multiple enumeration characters

Allow for installation of grub on devices such as /dev/sdaa or
/dev/xvdab.
---
 grub-installer | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-installer b/grub-installer
index 2b61fb6..cce326f 100755
--- a/grub-installer
+++ b/grub-installer
@@ -252,7 +252,7 @@ case $prefix in
     /dev/mapper)
        disc_offered_devfs="$bootfs"
        ;;
-    
/dev/[hsv]d[a-z0-9]|/dev/xvd[a-z]|/dev/cciss/c[0-9]d[0-9]*|/dev/ida/c[0-9]d[0-9]*|/dev/rs/c[0-9]d[0-9]*|/dev/mmcblk[0-9]|/dev/ad[0-9]*|/dev/da[0-9]*)
+    
/dev/[hsv]d[a-z0-9]|/dev/[sv]d[a-z][a-z]*|/dev/xvd[a-z]*|/dev/cciss/c[0-9]d[0-9]*|/dev/ida/c[0-9]d[0-9]*|/dev/rs/c[0-9]d[0-9]*|/dev/mmcblk[0-9]|/dev/ad[0-9]*|/dev/da[0-9]*)
        disc_offered_devfs="$prefix"
        ;;
     *)
-- 
2.1.1

Reply via email to