On 30 Jul 2011, at 15:57, Ian Campbell wrote: > On Sat, 2011-07-30 at 15:28 +0100, Dominic Benson wrote: >> >> OK. I'm not really sure under what real circumstances it would be entered. >> >> My concern was that, if it is used, as /sys/bus/xen and /dev/hvc0 must >> both exist, two inittab lines would be produced with the same id. >> It strikes me that that would be in some way bad, although I haven't >> tried it. > > The $DT stuff is for systems using Device Tree with an HVC console and > not any system currently supported by Xen (it's used by e.g. a PowerPC > hypervisor, I think). It appears that the DT stuff is checking for > specific machines and/or explicit hvc0 configurations. > > However we may as well switch the Xen case "if" into an "elif" after the > DT case, then if a system which uses both Xen and DT appears it will > only hit the DT case (which would be arguably the more correct one to > trust in those circumstances).
Ahh, that sounds like a good plan in that case. The adjusted patch looks fine to me. [there remains no currently effective 'is XEN' test, but using /dev/hvc0, if it exists, precisely once, sounds reasonable] Dominic -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1809a69a-bb69-4f96-8d02-bf20b5ebf...@thirdlight.com
