Chris Lamb wrote: > Anyway, if there is no objection to the approach I'll prepare a patch > and post it back here.
Attached.
- apt-setup is lacking a versioned dependency on cdrom-detect >= 1.32,
but I can't see a way of doing that.
- Templates say stuff like "looking from CD-ROM", "loading from
CD-ROM". We (Debian Live) don't care so much about that right now,
but it would be nice to fix.
- I have a test image here at DebConf that I can easily share
locally (150MB).
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org
`-
From 0facd51c06088d997596c14d510354a150bf3b12 Mon Sep 17 00:00:00 2001
From: Chris Lamb <la...@debian.org>
Date: Fri, 24 Jul 2009 19:30:46 +0200
Subject: [PATCH 1/6] Add "usb-partition" argument to list-devices for detecting partitions on USB drives. Patch originally by Tormod Volden <debian.tor...@gmail.com>.
---
packages/debian-installer-utils/debian/changelog | 7 +++++++
packages/debian-installer-utils/list-devices | 17 +++++++++++++++--
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/packages/debian-installer-utils/debian/changelog b/packages/debian-installer-utils/debian/changelog
index d59202f..a8eb223 100644
--- a/packages/debian-installer-utils/debian/changelog
+++ b/packages/debian-installer-utils/debian/changelog
@@ -1,3 +1,10 @@
+debian-installer-utils (1.72) UNRELEASED; urgency=low
+
+ * Add "usb-partition" argument to list-devices for detecting partitions on
+ USB drives. Patch originally by Tormod Volden <debian.tor...@gmail.com>.
+
+ -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:21:43 +0200
+
debian-installer-utils (1.71) unstable; urgency=low
[ Luca Favatella ]
diff --git a/packages/debian-installer-utils/list-devices b/packages/debian-installer-utils/list-devices
index b748be9..2a95b71 100755
--- a/packages/debian-installer-utils/list-devices
+++ b/packages/debian-installer-utils/list-devices
@@ -6,9 +6,9 @@ case $TYPE in
logger -t list-devices "deprecated parameter maybe-floppy"
TYPE=floppy
;;
- cd|disk|partition|floppy|maybe-usb-floppy) ;;
+ cd|disk|partition|floppy|maybe-usb-floppy|usb-partition) ;;
*)
- echo "Usage: $0 cd|disk|partition|floppy|maybe-usb-floppy" >&2
+ echo "Usage: $0 cd|disk|partition|floppy|maybe-usb-floppy|usb-partition" >&2
exit 2
;;
esac
@@ -40,6 +40,12 @@ case $TYPE in
# Also allow misdetected USB devices
scan_partition=:
;;
+ usb-partition)
+ for x in /sys/block/*/*; do
+ [ -d "$x" ] || continue
+ syspaths="${syspaths:+$syspaths }$x"
+ done
+ ;;
*)
for x in /sys/block/*; do
[ -d "$x" ] || continue
@@ -85,6 +91,13 @@ for x in $syspaths; do
match=:
fi
fi
+ # Disk partitions, but only on USB drives
+ if ! $match && [ "$TYPE" = usb-partition ]; then
+ if device_info env "$devpath" | grep -q '^ID_BUS=usb' && \
+ device_info env "$devpath" | grep -q '^ID_TYPE=disk'; then
+ match=:
+ fi
+ fi
if $match; then
if ! name="$(device_info name "$devpath")"; then
name="$(printf %s "${devpath##*/}" | \
--
1.6.3.3
From da4b87b041a477d41894d8f61d89101c53183983 Mon Sep 17 00:00:00 2001 From: Chris Lamb <la...@debian.org> Date: Fri, 24 Jul 2009 19:42:04 +0200 Subject: [PATCH 2/6] Append " fstype=iso9660" to mounting status messages. --- packages/cdrom-detect/debian/cdrom-detect.postinst | 9 +++++---- packages/cdrom-detect/debian/changelog | 6 ++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/packages/cdrom-detect/debian/cdrom-detect.postinst b/packages/cdrom-detect/debian/cdrom-detect.postinst index da0c1bb..5ead814 100755 --- a/packages/cdrom-detect/debian/cdrom-detect.postinst +++ b/packages/cdrom-detect/debian/cdrom-detect.postinst @@ -35,12 +35,12 @@ do devices="$(list-devices cd; list-devices maybe-usb-floppy)" for device in $devices; do if mount -t iso9660 -o ro,exec $device /cdrom; then - log "CD-ROM mount succeeded: device=$device" + log "CD-ROM mount succeeded: device=$device fstype=iso9660" mounted=1 db_set cdrom-detect/cdrom_device $device break else - log "CD-ROM mount failed: device=$device" + log "CD-ROM mount failed: device=$device fstype=iso9660" fi done @@ -102,11 +102,12 @@ do modprobe $module fi if mount -t iso9660 -o ro,exec $device /cdrom; then - log "CD-ROM mount succeeded: device=$device" + log "CD-ROM mount succeeded: device=$device fstype=iso9660" + db_set cdrom-detect/cdrom_fs iso9660 mounted=1 break else - log "CD-ROM mount failed: device=$device" + log "CD-ROM mount failed: device=$device fstype=iso9660" fail fi else diff --git a/packages/cdrom-detect/debian/changelog b/packages/cdrom-detect/debian/changelog index 5e0db37..6441890 100644 --- a/packages/cdrom-detect/debian/changelog +++ b/packages/cdrom-detect/debian/changelog @@ -1,3 +1,9 @@ +cdrom-detect (1.32) UNRELEASED; urgency=low + + * Append " fstype=iso9660" to mounting status messages. + + -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:40:11 +0200 + cdrom-detect (1.31) unstable; urgency=low [ Updated translations ] -- 1.6.3.3
From 02215995f9a739daa1a3188c24990cdeb53213e9 Mon Sep 17 00:00:00 2001
From: Chris Lamb <la...@debian.org>
Date: Fri, 24 Jul 2009 19:45:20 +0200
Subject: [PATCH 3/6] Try mounting USB block devices if cdrom-detect/try-usb is true. We reject the mountpoint if it does not have /.disk/info file. (Closes: #498143)
---
packages/cdrom-detect/debian/cdrom-detect.postinst | 20 ++++++++++++++++++++
.../cdrom-detect/debian/cdrom-detect.templates | 5 +++++
packages/cdrom-detect/debian/changelog | 4 +++-
packages/cdrom-detect/debian/control | 2 +-
4 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/packages/cdrom-detect/debian/cdrom-detect.postinst b/packages/cdrom-detect/debian/cdrom-detect.postinst
index 5ead814..ca38cb1 100755
--- a/packages/cdrom-detect/debian/cdrom-detect.postinst
+++ b/packages/cdrom-detect/debian/cdrom-detect.postinst
@@ -32,6 +32,26 @@ while true
do
mounted=0
+ if db_get cdrom-detect/try-usb && [ "$RET" = "true" ]; then
+ devices="$(list-devices usb-partition)"
+ for device in $devices; do
+ if mount -t vfat -o ro,exec $device /cdrom &&
+ [ -e /cdrom/.disk/info ]; then
+ log "CD-ROM mount succeeded: device=$device fstype=vfat"
+ mounted=1
+ db_set cdrom-detect/cdrom_device $device
+ break
+ else
+ log "CD-ROM mount failed: device=$device fstype=vfat"
+ umount /cdrom 2>/dev/null || true
+ fi
+ done
+ fi
+
+ if [ "$mounted" = "1" ]; then
+ break
+ fi
+
devices="$(list-devices cd; list-devices maybe-usb-floppy)"
for device in $devices; do
if mount -t iso9660 -o ro,exec $device /cdrom; then
diff --git a/packages/cdrom-detect/debian/cdrom-detect.templates b/packages/cdrom-detect/debian/cdrom-detect.templates
index 878f474..32e7615 100644
--- a/packages/cdrom-detect/debian/cdrom-detect.templates
+++ b/packages/cdrom-detect/debian/cdrom-detect.templates
@@ -123,3 +123,8 @@ Type: text
# Item in the main menu to select this package
# :sl2:
_Description: Detect and mount CD-ROM
+
+Template: cdrom-detect/try-usb
+Type: boolean
+Description: for internal use only
+ Preseed this to true to try to mount /cdrom from USB partitions.
diff --git a/packages/cdrom-detect/debian/changelog b/packages/cdrom-detect/debian/changelog
index 6441890..98bb958 100644
--- a/packages/cdrom-detect/debian/changelog
+++ b/packages/cdrom-detect/debian/changelog
@@ -1,8 +1,10 @@
cdrom-detect (1.32) UNRELEASED; urgency=low
* Append " fstype=iso9660" to mounting status messages.
+ * Try mounting USB block devices if cdrom-detect/try-usb is true. We reject
+ the mountpoint if it does not have /.disk/info file. (Closes: #498143)
- -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:40:11 +0200
+ -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:43:27 +0200
cdrom-detect (1.31) unstable; urgency=low
diff --git a/packages/cdrom-detect/debian/control b/packages/cdrom-detect/debian/control
index 0028eb3..e31a6ff 100644
--- a/packages/cdrom-detect/debian/control
+++ b/packages/cdrom-detect/debian/control
@@ -10,6 +10,6 @@ Vcs-Svn: svn://svn.debian.org/d-i/trunk/packages/cdrom-detect
Package: cdrom-detect
XC-Package-Type: udeb
Architecture: all
-Depends: ${misc:Depends}, hw-detect, di-utils (>= 1.48)
+Depends: ${misc:Depends}, hw-detect, di-utils (>= 1.72)
XB-Installer-Menu-Item: 1300
Description: Detect CDROM devices and mount the CD
--
1.6.3.3
From a1f70f2be1bf0dcdb548d7aa14ebccfc94370754 Mon Sep 17 00:00:00 2001
From: Chris Lamb <la...@debian.org>
Date: Fri, 24 Jul 2009 20:02:21 +0200
Subject: [PATCH 4/6] Set the filesystem type in cdrom-detect/cdrom_fs for apt-setup's benefit.
---
packages/cdrom-detect/debian/cdrom-detect.postinst | 2 ++
.../cdrom-detect/debian/cdrom-detect.templates | 6 ++++++
packages/cdrom-detect/debian/changelog | 3 ++-
3 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/packages/cdrom-detect/debian/cdrom-detect.postinst b/packages/cdrom-detect/debian/cdrom-detect.postinst
index ca38cb1..5a2de60 100755
--- a/packages/cdrom-detect/debian/cdrom-detect.postinst
+++ b/packages/cdrom-detect/debian/cdrom-detect.postinst
@@ -40,6 +40,7 @@ do
log "CD-ROM mount succeeded: device=$device fstype=vfat"
mounted=1
db_set cdrom-detect/cdrom_device $device
+ db_set cdrom-detect/cdrom_fs vfat
break
else
log "CD-ROM mount failed: device=$device fstype=vfat"
@@ -58,6 +59,7 @@ do
log "CD-ROM mount succeeded: device=$device fstype=iso9660"
mounted=1
db_set cdrom-detect/cdrom_device $device
+ db_set cdrom-detect/cdrom_fs iso9660
break
else
log "CD-ROM mount failed: device=$device fstype=iso9660"
diff --git a/packages/cdrom-detect/debian/cdrom-detect.templates b/packages/cdrom-detect/debian/cdrom-detect.templates
index 32e7615..9e01795 100644
--- a/packages/cdrom-detect/debian/cdrom-detect.templates
+++ b/packages/cdrom-detect/debian/cdrom-detect.templates
@@ -59,6 +59,12 @@ _Description: Device file for accessing the CD-ROM:
available devices in /dev with "ls /dev". You can return to this screen
by pressing ALT+F1.
+Template: cdrom-detect/cdrom_fs
+Type: string
+Default: iso9660
+Description: for internal use only
+ File system used on cdrom-detect/cdrom_device.
+
Template: cdrom-detect/scanning_progress_title
Type: text
# :sl1:
diff --git a/packages/cdrom-detect/debian/changelog b/packages/cdrom-detect/debian/changelog
index 98bb958..5dbfe45 100644
--- a/packages/cdrom-detect/debian/changelog
+++ b/packages/cdrom-detect/debian/changelog
@@ -3,8 +3,9 @@ cdrom-detect (1.32) UNRELEASED; urgency=low
* Append " fstype=iso9660" to mounting status messages.
* Try mounting USB block devices if cdrom-detect/try-usb is true. We reject
the mountpoint if it does not have /.disk/info file. (Closes: #498143)
+ * Set the filesystem type in cdrom-detect/cdrom_fs for apt-setup's benefit.
- -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:43:27 +0200
+ -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:59:23 +0200
cdrom-detect (1.31) unstable; urgency=low
--
1.6.3.3
From 2371d83e2bee997ae859a8210b06d09b23274b75 Mon Sep 17 00:00:00 2001
From: Chris Lamb <la...@debian.org>
Date: Fri, 24 Jul 2009 19:58:21 +0200
Subject: [PATCH 5/6] Use cdrom-detect/cdrom_fs when remounting the CD to ensure that we do so using the same filesystem. Patch by Colin Watson, merged back from Ubuntu.
---
packages/apt-setup/debian/changelog | 7 +++++++
packages/apt-setup/generators/40cdrom | 6 +++++-
packages/apt-setup/load-install-cd | 6 +++++-
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/packages/apt-setup/debian/changelog b/packages/apt-setup/debian/changelog
index 5752e85..dd8b918 100644
--- a/packages/apt-setup/debian/changelog
+++ b/packages/apt-setup/debian/changelog
@@ -1,3 +1,10 @@
+apt-setup (1:0.43) UNRELEASED; urgency=low
+
+ * Use cdrom-detect/cdrom_fs when remounting the CD to ensure that we do so
+ using the same filesystem. Patch by Colin Watson, merged back from Ubuntu.
+
+ -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:56:31 +0200
+
apt-setup (1:0.42) unstable; urgency=low
[ Colin Watson ]
diff --git a/packages/apt-setup/generators/40cdrom b/packages/apt-setup/generators/40cdrom
index a274d1f..09bba76 100755
--- a/packages/apt-setup/generators/40cdrom
+++ b/packages/apt-setup/generators/40cdrom
@@ -11,8 +11,12 @@ fi
remount_cd() {
if [ "$ROOT" ] && [ ! -d /hd-media ]; then
+ fs=iso9660
+ if db_get cdrom-detect/cdrom_fs && [ "$RET" ]; then
+ fs="$RET"
+ fi
db_get cdrom-detect/cdrom_device
- $logoutput mount -t iso9660 -o ro,exec $RET /cdrom || true
+ $logoutput mount -t "$fs" -o ro,exec $RET /cdrom || true
fi
}
diff --git a/packages/apt-setup/load-install-cd b/packages/apt-setup/load-install-cd
index f3c8fac..ccf9bb5 100755
--- a/packages/apt-setup/load-install-cd
+++ b/packages/apt-setup/load-install-cd
@@ -29,5 +29,9 @@ while ! check_id; do
db_go || exit 10
done
+fs=iso9660
+if db_get cdrom-detect/cdrom_fs && [ "$RET" ]; then
+ fs="$RET"
+fi
db_get cdrom-detect/cdrom_device
-$logoutput mount -t iso9660 -o ro,exec $RET /cdrom
+$logoutput mount -t "$fs" -o ro,exec $RET /cdrom
--
1.6.3.3
From f3baea3196392aa2505f85d5117a069810a98119 Mon Sep 17 00:00:00 2001
From: Chris Lamb <la...@debian.org>
Date: Sat, 25 Jul 2009 19:09:43 +0200
Subject: [PATCH 6/6] Don't try and run apt-cdrom for vfat "CD-ROMs"
---
packages/apt-setup/debian/changelog | 3 ++-
packages/apt-setup/generators/40cdrom | 13 +++++++++----
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/packages/apt-setup/debian/changelog b/packages/apt-setup/debian/changelog
index dd8b918..089e1ac 100644
--- a/packages/apt-setup/debian/changelog
+++ b/packages/apt-setup/debian/changelog
@@ -2,8 +2,9 @@ apt-setup (1:0.43) UNRELEASED; urgency=low
* Use cdrom-detect/cdrom_fs when remounting the CD to ensure that we do so
using the same filesystem. Patch by Colin Watson, merged back from Ubuntu.
+ * Don't try and run apt-cdrom for non-ISO9660 "CD-ROMs".
- -- Chris Lamb <la...@debian.org> Fri, 24 Jul 2009 19:56:31 +0200
+ -- Chris Lamb <la...@debian.org> Sat, 25 Jul 2009 17:49:25 +0200
apt-setup (1:0.42) unstable; urgency=low
diff --git a/packages/apt-setup/generators/40cdrom b/packages/apt-setup/generators/40cdrom
index 09bba76..ad6ddd1 100755
--- a/packages/apt-setup/generators/40cdrom
+++ b/packages/apt-setup/generators/40cdrom
@@ -9,12 +9,17 @@ if [ ! -e /cdrom/.disk/base_installable ]; then
exit 0
fi
+fs=iso9660
+if db_get cdrom-detect/cdrom_fs && [ "$RET" ]; then
+ fs="$RET"
+fi
+
+if [ "$fs" != "iso9660" ]; then
+ exit 0
+fi
+
remount_cd() {
if [ "$ROOT" ] && [ ! -d /hd-media ]; then
- fs=iso9660
- if db_get cdrom-detect/cdrom_fs && [ "$RET" ]; then
- fs="$RET"
- fi
db_get cdrom-detect/cdrom_device
$logoutput mount -t "$fs" -o ro,exec $RET /cdrom || true
fi
--
1.6.3.3
signature.asc
Description: PGP signature
