On Tuesday 11 November 2008, Frank Lin PIAT wrote: > Here's a proper patch against SVN repository: > > I'll try to build a CD, and test it tomorrow on some computers at work.
I'm afraid that IMO this patch is not a very good idea. First of all, as it is, it is incomplete and breaks other installation methods (in fact, I think the change in config/x86.cfg is wrong for CD). But that could be fixed. More importantly, I think it will break the addition of boot options by the user, for example booting with 'install noapic'. Or are they preserved somehow? Even if they are preserved, are they preserved *correctly*? I.e. appended (not prepended) to the append lines defined in the options you jump to, and without adding any extra "--". And last but not least I feel that it is a too elaborate patch to support multi-arch, which is after all an exception, and makes the far more common single-arch use case needlessly complicated. I still feel that the basic problem is not in D-I, but in syslinux and the best option for Lenny may still be to just comment out 'default64 amd64-install' and accept the resulting (minor) erratum. The information that was gathered while tracking this issue down is very valuable. We now have a much better understanding of the problem and what does not work/could work. And I really like the option to jump back to the menu from the help screens. I'll try to do some testing myself today on this issue. Cheers, FJP
signature.asc
Description: This is a digitally signed message part.
