-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Otavio Salvador wrote: > Glenn Saberton <[EMAIL PROTECTED]> writes: > >> Jérémy Bobbio wrote: >>> On Wed, Aug 13, 2008 at 05:53:03PM +0800, Glenn Saberton wrote: >>>> After looking at finnish-install, the speakup script looked like a nice >>>> way to do it. Heres a preliminary patch. tested and installed the >>>> correct flavour kernel for my eee. >>> Good. :) >>> >>>> […] >>>> +ATL2=$(lsmod | grep ^atl2 | cut -d" " -f1) >>>> +if [ -n "$ATL2" ]; then >>> What about symplifing this to the following: >>> >>> if lsmod | grep -q '^atl2 '; then >>> >>> Otherwise, looks fine to me. >>> Cheers, >> Yep, works fine, tested and installed the 686 modules correctly. Heres >> the new patch. >> >> >> diff --git a/packages/finish-install/debian/rules >> b/packages/finish-install/debian/rules >> index ffd8c39..976f7b3 100755 >> --- a/packages/finish-install/debian/rules >> +++ b/packages/finish-install/debian/rules >> @@ -4,6 +4,7 @@ DESTDIR = debian/finish-install >> >> scripts = \ >> 05speakup \ >> + 07atl2 \ >> 10bind-mount \ >> 20final-message \ >> 50config-target-network \ >> diff --git a/packages/finish-install/finish-install.d/07atl2 >> b/packages/finish-install/finish-install.d/07atl2 >> new file mode 100755 >> index 0000000..5d66b7a >> --- /dev/null >> +++ b/packages/finish-install/finish-install.d/07atl2 >> @@ -0,0 +1,9 @@ >> +#!/bin/sh >> + >> +. /usr/share/debconf/confmodule >> + >> +if lsmod|grep -q '^atl2'; then >> + db_get base-installer/kernel/image >> + KVERS=${RET#*-image-} >> + apt-install atl2-modules-$KVERS 1>&2 >> + fi > > Could you fix the coding style? The fi is using a wrong identation. >
Will do. Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkiuzxgACgkQV8GyuTwyskM+qwCfRC+vZ6q69+dG7eDrx+vVgvvx 2TwAnA6xmap6TyBLGPUHJtVHssbXd3tC =ouD2 -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]