Your message dated Sat, 2 Aug 2008 09:15:39 +0200 with message-id <[EMAIL PROTECTED]> and subject line Re: Bug#493139: iso-scan: Allow using shell patterns to select ISO images has caused the Debian Bug report #493139, regarding iso-scan: Allow using shell patterns to select ISO images to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 493139: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493139 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: iso-scan Severity: wishlist Tags: patch The following patch allows one to select ISO images in iso-scan. With this patch grub configurations as exampled below can be used to perform an i386 or amd64 hd-media installation: title New Debian Installation - i386 root (hd0,0) kernel (hd0,0)/images/i386/hd-media/vmlinuz iso-scan/files=*i386*.iso initrd (hd0,0)/images/i386/hd-media/initrd.gz title New Debian Installation - amd64 root (hd0,0) kernel (hd0,0)/images/amd64/hd-media/vmlinuz iso-scan/files=*amd64*.iso initrd (hd0,0)/images/amd64/hd-media/initrd.gz Note that, the patch preserves the current behaviour. -- roktasdiff --git a/packages/iso-scan/debian/iso-scan.postinst b/packages/iso-scan/debian/iso-scan.postinst index da354cc..80b4a3f 100755 --- a/packages/iso-scan/debian/iso-scan.postinst +++ b/packages/iso-scan/debian/iso-scan.postinst @@ -112,6 +112,10 @@ modprobe loop >/dev/null || true mkdir /cdrom 2>/dev/null || true mkdir /hd-media 2>/dev/null || true +db_get iso-scan/files || RET='' +ISO_FILES="${RET:-'*.[iI][sS][oO]'}" +log "Using '$ISO_FILES' pattern for ISO files." + log "First pass: Look for ISOs near top-level of each filesystem." DEVS="$(list-devices partition; list-devices disk; list-devices maybe-usb-floppy)" # Repeat twice if necessary, to accomodate devices that need some @@ -145,12 +149,14 @@ for i in 1 2; do fi db_subst iso-scan/progress_scan DIRECTORY "$dir/" db_progress INFO iso-scan/progress_scan - for iso in $dir/*.iso $dir/*.ISO; do - if [ -e $iso ]; then - log "Found ISO $iso on $dev" - ISO_COUNT=$(expr $ISO_COUNT + 1) - try_iso $iso $dev - fi + for pattern in $ISO_FILES; do + for iso in $dir/$pattern; do + if [ -e $iso ]; then + log "Found ISO $iso on $dev" + ISO_COUNT=$(expr $ISO_COUNT + 1) + try_iso $iso $dev + fi + done done fi done
--- End Message ---
--- Begin Message ---On Sat, Aug 02, 2008 at 02:25:23AM +0300, Recai Oktaş wrote: > * Recai Oktaş [2008-07-31 23:16:43+0300] > > * Joey Hess [2008-07-31 14:05:22-0400] > > > Recai Oktaş wrote: > > > > The following patch allows one to select ISO images in iso-scan. With > > > > this > > > > patch grub configurations as exampled below can be used to perform an > > > > i386 > > > > or amd64 hd-media installation: > > > > > > iso-scan already checks what architecture the iso is for. Why do you > > > need a second, filename-based architecture check? > > > > Did you mean the ISO selection logic in register_cd (which I'm not aware > > of)? If so, forget my patch[1]. My previous attempts to use multiple ISOs > > had been failed, probably for unrelated reasons. I'll make a new test and > > let you know. > > Ok, I've managed to make i386 and am64 installations from an external hdd > containing multiple ISOs (great!). My previous failed attempts must be > related to incorrect ISOs. > > Feel free to close this bug report. Sorry for the fuss! Done. :) Cheers, -- Jérémy Bobbio .''`. [EMAIL PROTECTED] : :Ⓐ : # apt-get install anarchism `. `'` `-
signature.asc
Description: Digital signature
--- End Message ---
