tags 479391 + patch thanks On Sun, May 04, 2008 at 08:03:39PM +0200, Frans Pop wrote: > On Sunday 04 May 2008, Thijs Kinkhorst wrote: > > I'm not knowledgable of D-I internals, but why couldn't you make the > > second question conditional of the first, like in this example (untested, > > just to show what I mean): > > Because we _want_ them on the same screen in the graphical installer, so > they have to be part of the same db_go which means you don't have the reply > to the first db_input yet.
Attached is a patch that would solve this issue. Quoting the commit
log:
Ask about PCMCIA resource conditionally on text/newt frontend
On frontends other than GTK+, the question about PCMCIA resource range
is now only asked if the user decided to start PCMCIA.
I know that this break the rule of acting independently of the frontend
used, but I am really sick of users mentioning this issue in
installation reports.
Cheers,
--
Jérémy Bobbio .''`.
[EMAIL PROTECTED] : :Ⓐ : # apt-get install anarchism
`. `'`
`-
commit 5eed313511db557322cf5a136030559d0325032e
Author: Jérémy Bobbio <[EMAIL PROTECTED]>
Date: Mon Jul 28 19:35:14 2008 +0200
Ask about PCMCIA resource conditionally on text/newt frontend
On frontends other than GTK+, the question about PCMCIA resource range
is now only asked if the user decided to start PCMCIA.
I know that this break the rule of acting independently of the frontend
used, but I am really sick of users mentioning this issue in
installation reports.
(Closes: #479391)
diff --git a/packages/hw-detect/debian/changelog b/packages/hw-detect/debian/changelog
index 8cac812..b59a13d 100644
--- a/packages/hw-detect/debian/changelog
+++ b/packages/hw-detect/debian/changelog
@@ -1,3 +1,11 @@
+hw-detect (1.66) UNRELEASED; urgency=low
+
+ [ Jérémy Bobbio ]
+ * On frontends other than GTK+, only ask about PCMCIA resource range when
+ user decided to start PCMCIA. (Closes: #479391)
+
+ -- Jérémy Bobbio <[EMAIL PROTECTED]> Mon, 28 Jul 2008 19:27:56 +0200
+
hw-detect (1.65) unstable; urgency=low
[ Joey Hess ]
diff --git a/packages/hw-detect/hw-detect.sh b/packages/hw-detect/hw-detect.sh
index 302ea4d..d297add 100755
--- a/packages/hw-detect/hw-detect.sh
+++ b/packages/hw-detect/hw-detect.sh
@@ -428,8 +428,21 @@ fi
if [ "$PCMCIA_INIT" ]; then
if is_not_loaded pcmcia_core; then
db_input medium hw-detect/start_pcmcia || true
- db_input low hw-detect/pcmcia_resources || true
+
+ # Ask resources at the same time on GTK+ frontend
+ if [ "$DEBIAN_FRONTEND" = "gtk" ]; then
+ db_input low hw-detect/pcmcia_resources || true
+ fi
db_go || true
+
+ # For other frontends, ask only if PCMCIA shoul be started
+ if ! [ "$DEBIAN_FRONTEND" = "gtk" ]; then
+ db_get hw-detect/start_pcmcia || true
+ if [ "$RET" = true ]; then
+ db_input low hw-detect/pcmcia_resources || true
+ db_go || true
+ fi
+ fi
if db_get hw-detect/pcmcia_resources && [ "$RET" ]; then
apply_pcmcia_resource_opts $RET
fi
signature.asc
Description: Digital signature
