On Sunday 20 July 2008, I wrote: > On Sunday 20 July 2008, Jérémy Bobbio wrote: > > The attached patch should fix the issue. Details in its header. > > Doesn't this introduce an inconsistency between what is input and what > is displayed in the "Current LVM configuration" dialog?
Consistency between D-I and commands given from shell is another factor to take into account. Fact is that LVM by default uses binary-based units while e.g. disk manufacturers and fdisk use SI units. Partman is currently consistent with that. It may not be internally consistent, but it may also be just what some users (e.g. experienced sysadmins) expect. The problem in this BR is basically that the units for the displayed default size currently do not match the how the units that are input are used, which definitely is a bug and one that your patch does seem to fix. But it could also be solved by having the proposed value displayed in binary-based units... This also somewhat clashes with Robert's patch in #471323, which goes the other direction. I'd much rather see an inventory of what partman does _as a whole_ and a proposal/discussion how we can make it consistent and clear to the user what units are used/expected/displayed for partman _as a whole_ than to introduce such "random" changes based on a single aspect of the problem. I do agree there is a (fairly big) consistency problem, but I'm not sure this is the way nor the time to fix it. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
