Hi! On Thu, 2023-10-26 at 12:55:32 +0200, Guillem Jover wrote: > On Thu, 2023-10-26 at 11:40:53 +0200, Emanuele Rocca wrote: > > Package: dpkg-dev > > Version: 1.22.0 > > Severity: normal
> > -fstack-clash-protection is supposed to be enabled by default on amd64, > > arm64, armhf, and armel since dpkg 1.22.0: > > https://git.dpkg.org/cgit/dpkg/dpkg.git/diff/?id=11efff1bf > > > > However, due to an issue in the following conditional in > > scripts/Dpkg/Vendor/Debian.pm, the flag is only on for amd64 and arm64: > > > > if (none { $cpu eq $_ } qw(amd64 arm64 armhf armel)) { > > > > The value of $cpu is "arm" for both armhf and armel. Please change the > > line above to: > > > > if (none { $cpu eq $_ } qw(amd64 arm64 arm)) { > > Ah, nice catch, and sorry! I think this happened due to copy pasting > and modifying one of the surrounding lines. The intention was to use > $arch here, to avoid enabling this on all arm-based arches which might > not support this. I've queued the attached patch for my next push. Checking now again, I realize Wookey mentioned enabling this for the 3 arm arches (those would be arm64, armhf and armel), so the patch I provided would match that. But I was wondering now what about armeb and arm64ilp32? I mean, I assume those should be excluded for now as they did not get any testing, and they might not even be used/lively(?), but wanted to ask in any case before pushing. If I don't hear anything before the release, I'll just push what I proposed, and we can always enabled these later on if needed. Thanks, Guillem
