Hello, Yes, I agree that's a better thing to do, and I completely missed that point in Magnus's email (my apologies). And defining __LINUX__ seems like the wrong thing to do if what you want to test is if you need to #include <endian.h>, that's just how md5.c handles it now. That can be changed to a small test program that runs makemd5() and sees if it generates the right hash or not; I don't know if you wouldn't still want to "-D__`uname -s | tr a-z A-Z__" for all, for when things like GNU C library headers that would check what kernel you're using and handle things differently.
Jesse ---- Original Message ---- From: Aaron Stone <dbmail@dbmail.org> To: dbmail@dbmail.org Subject: Re: [Dbmail] PATCH: dbmail_configure_check_os.patch Sent: Sat, 1 Mar 2003 00:58:48 -0800 (PST) Magnus has an important point: don't check for an OS, check for what its behavior is. I believe that in this case, we're talking about activating parts of a system-dependent header with this flag. That the flag is system dependent is not at issue; it's how we test that. If the approach is like this... "Does blah.h work? No? What about if we add -D__LINUX__? Works? Good!" then we're doing The Right Thing (TM). If the approach is like this: "if( uname -a | grep Linux )" then we're way off in left field. Aaron On Fri, 28 Feb 2003, Jesse Norell wrote: > > Hello Magnus, > > > What I suggest is that you test for the LINUX capabilities in the > > configure script. By this way will the software be much more portable to > > other operating systems. > > You apparently misunderstood what Ryan said; this is exactly what > the patch does. Just run ./configure and if you're on a linux system > you get -D__LINUX__ included in your compile. > > > > My belief is that the operating system is of none importance. It's the > > library and system calls that the application depend upon. > > In this case it's a requisite .h file gets included, but it's > follows the same train of thought. > > Jesse > > > -- > Jesse Norell > [EMAIL PROTECTED] > _______________________________________________ > Dbmail mailing list > Dbmail@dbmail.org > https://mailman.fastxs.nl/mailman/listinfo/dbmail > _______________________________________________ Dbmail mailing list Dbmail@dbmail.org https://mailman.fastxs.nl/mailman/listinfo/dbmail -- End Original Message -- -- Jesse Norell [EMAIL PROTECTED]
