Hi Pascal,

I did fetch, rebase, intltool-update, and it remains commented out.
I see it is not commented out in most languages:

$ grep "film stock" *
af.po:#~ msgid "film stock"
cs.po:msgid "film stock"
de.po:#~ msgid "film stock"
es.po:#~ msgid "film stock"
fr.po:msgid "film stock"
he.po:msgid "film stock"
hu.po:msgid "film stock"
it.po:msgid "film stock"
nl.po:msgid "film stock"
pl.po:msgid "film stock"
pt_BR.po:#~ msgid "film stock"
ru.po:msgid "film stock"
sl.po:#~ msgid "film stock"

but:

$ git fetch upstream master
>From https://github.com/darktable-org/darktable
 * branch                master     -> FETCH_HEAD

$ git rebase upstream/master
Current branch pt_BR is up to date.

$ intltool-update pt_BR
..........................................................................................................................................................................................................................................................................................................................................................................................................
 done.
3715 translated messages.

$ grep "film stock" pt_BR.po
#~ msgid "film stock"

I am confused...

J.

Pascal Obry <pas...@obry.net> writes:

> Hi Jeronimo,
>
>> Did this get into github? I fetched today and didn't see anything new
>> (neither in darktable's translations, checked with intltool-update,
>> nor in the manual, checked with make update-usermanual-pt_BR).
>
> Yes and your .po was changed (see that "film stock" translation is not
> commented out anymore). As I said this was in 3.2, was translated and
> got commented out because the string was not removed anymore. Just
> doing an update will un-comment the translation (of course if this was
> already translated in 3.2).
>
> So you just have to issue a new PR with your modified PO.
>
> -- 
>   Pascal Obry /  Magny Les Hameaux (78)
>
>   The best way to travel is by means of imagination
>
>   http://www.obry.net
>
>   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Reply via email to