Will have a look in the next few days. Le 15/11/2019 à 21:10, Nicolas Auffray a écrit : > Timur, see here for issue posted : > https://github.com/darktable-org/darktable/issues/3445 > > I'm now waiting for someone with GTK/Cairo skills. > > > Le 15/11/2019 à 20:55, Nicolas Auffray a écrit : >> I just look on that and color pickers with hover background are >> indeed buttons gtk items as color pickers in filmic rgb, exposer, >> color balance, tone equalizer (or some other modules) are not button >> widget ones but seems included in bauhaus-slider widget (or with). >> And these ones doesn't have specific CSS tag so I can't change that >> with CSS as it is without adding other glitches. So probably need a >> GTK code change to make all color pickers here have same behavior. I >> will post an issue on Github. >> >> >> Le 15/11/2019 à 20:12, Nicolas Auffray a écrit : >>> Oups, sorry I just see that I was not on same color pickers than >>> you. We recently update color pickers on levels modules and I don't >>> know why, by answering you, I was thinking of that levels modules >>> (so the black, grey and white pickers I was pointing) and not the >>> curve rgb one... >>> >>> I've just edited an image and opening curve rgb (not level...) and I >>> now understand what you point. Indeed, you're right, this pickers >>> are the same as filmic, exposure or tones ones and not have the same >>> behavior. Again, sorry for my last answers, not on purpose... >>> >>> I will see if I can fix that with CSS this week-end. Thanks for >>> pointing that. >>> >>> Nicolas >>> >>> >>> Le 15/11/2019 à 19:41, Timur Irikovich Davletshin a écrit : >>>> Nic, I'm just saying that this behavior looks a bit confusing from >>>> user >>>> standpoint. >>>> >>>> I'm sorry for not posting to github. MS decided that I cannot use it — >>>> https://help.github.com/en/github/site-policy/github-and-trade-controls >>>> >>>> and I'm too lazy to use VPN for that purpose. >>>> >>>> Timur. >>>> >>>> P.S. there is no need to reply both to personal email and mailing >>>> list. >>>> >>>> On Fri, 2019-11-15 at 19:32 +0100, Nicolas Auffray wrote: >>>>> I have never say they are not pickers, just they are not same one... >>>>> Just see how they renders and where they are on modules UI. Size is >>>>> not >>>>> the same, and also color. just see that they are visibly >>>>> different... >>>>> But remember that it's an open source software, so feel free to >>>>> change >>>>> that the way you want if you don't like that, for you or you could >>>>> even >>>>> propose a PR on Github... Hmm.... >>>>> >>>>> Color pickers on curve modules are here to apply black, grey and >>>>> white >>>>> parts of curve (so they are colored in... black, grey, white). If >>>>> hover, >>>>> that could only be on background. Other color pickers are not related >>>>> to >>>>> black, grey and white. So if we had a hover effect, it would be >>>>> better >>>>> to do that just on the picker (not the background but the picker >>>>> himself). It's a possibility, but for me it's good as it is actually >>>>> (and nobody else seems to have problem with that...). That's my view >>>>> here ! >>>>> >>>>> >>>>> Le 15/11/2019 à 18:40, Timur Irikovich Davletshin a écrit : >>>>>> If they are not pickers why use same icon? And if all other icons >>>>>> have >>>>>> hover action, why not these? Hmm... >>>>>> >>>>>> Timur. >>>>>> >>>>>> On Fri, 2019-11-15 at 18:25 +0100, Nicolas Auffray wrote: >>>>>>> Hi Timur, >>>>>>> >>>>>>> It would really be better to post issues on Github (to let all >>>>>>> know >>>>>>> and >>>>>>> follow that). Anyway, some answers on what I see : >>>>>>> >>>>>>> 1. Yes, this icon doesn't seems to have CSS editing possibility >>>>>>> (maybe I >>>>>>> make a mistake but on what I see with GTK inspector...). So >>>>>>> posting >>>>>>> on >>>>>>> Github to let Aurélien see that (as it is his module work) would >>>>>>> be >>>>>>> better. >>>>>>> >>>>>>> 2 and 3. That's not issues. All color pickers like these ones >>>>>>> (see >>>>>>> exposure module for example) are displayed the same way. Color >>>>>>> picker >>>>>>> on >>>>>>> rgb curve are not same color picker (colored one, black, grey and >>>>>>> white >>>>>>> and not on same place like others color picker ; so having a >>>>>>> different >>>>>>> way is not a problem as they are not totally the same). Not >>>>>>> needed >>>>>>> to >>>>>>> have them have the exact same behavior. >>>>>>> >>>>>>> Nicolas >>>>>>> >>>>>>> >>>>>>> Le 15/11/2019 à 18:09, Timur Irikovich Davletshin a écrit : >>>>>>>> Hi developers! >>>>>>>> >>>>>>>> 1. tone equalizer module → display exposure mask icon has no >>>>>>>> hover >>>>>>>> background lightening. Compare with display mask icon in drawn >>>>>>>> mask >>>>>>>> blending. >>>>>>>> >>>>>>>> 2. Same problem in tone equalizer module → masking tab → picker >>>>>>>> tool >>>>>>>> next to mask exposure compensation and mask contrast >>>>>>>> compensation. >>>>>>>> >>>>>>>> 3. filmic rgb module → scene tab → four picker tools need hover >>>>>>>> background lightening. Compare with picker tool in rgb curve or >>>>>>>> tone >>>>>>>> curve. >>>>>>>> >>>>>>>> Thank you advance, >>>>>>>> >>>>>>>> Timur. >>>>>>>> >>>>>>>> _______________________________________________________________ >>>>>>>> ____ >>>>>>>> ________ >>>>>>>> darktable developer mailing list >>>>>>>> to unsubscribe send a mail to >>>>>>>> darktable-dev+unsubscr...@lists.darktable.org >>>>>>>> >>>>>> ___________________________________________________________________ >>>>>> ________ >>>>>> darktable developer mailing list >>>>>> to unsubscribe send a mail to >>>>>> darktable-dev+unsubscr...@lists.darktable.org >>>>>> >>>> ___________________________________________________________________________ >>>> >>>> darktable developer mailing list >>>> to unsubscribe send a mail to >>>> darktable-dev+unsubscr...@lists.darktable.org >>>> >>> >> >> ___________________________________________________________________________ >> >> darktable developer mailing list >> to unsubscribe send a mail to >> darktable-dev+unsubscr...@lists.darktable.org >> > > ___________________________________________________________________________ > > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org >
___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
