Just because you don’t agree with some design decisions made previously (I seem to remember that white balance was always on at some point), doesn’t mean you should introduce broken code. Correct fix is to add these 2 modules to the history, as I previously mentioned. Reverting them back to always-on I think is wrong, because technically they are not required (I think that was the reason to make them optional). This bug should be fixed somehow.
> On 13 Jun 2019, at 09:39, Aurélien Pierre <rese...@aurelienpierre.com> wrote: > > There is no image if the white balance has been disabled, just random bits > for debugging purposes. The input color profile expects D50-balanced input, > and this one is always on. Same with the highlight clipping module, most > software have it built in the input profile and don't expose it. Disable > these 2 and you mess up your whole module stack. > > So, again, what is the purpose of disabling these 2 modules, except for > debugging, and why can they be disabled at all but are still auto-applied at > opening ? > > The stack of exceptions handling in the SQL instructions smells bad. Things > should stay general. > >> Le 13/06/2019 à 08:36, para...@paraf.in a écrit : >> >> >> On 12 Jun 2019, at 20:21, Aurélien Pierre <rese...@aurelienpierre.com> wrote: >> >>> Hi, >>> >>> I'm the author of the lighttable's compress history button. White balance >>> and highlight reconstruction should never be turned off, so what would be >>> the purpose of having them disabled in the first place ? >>> >> >> Yet they can be disabled, some other modules can’t. >> >>> Then, we can discuss what the history compression should do/avoid/prevent. >>> >> >> History compression shouldn’t modify the image. >> >>> Aurélien. >>> >>>> Le 12/06/2019 à 11:40, dt-l...@stefan-klinger.de a écrit : >>>> thokster (2019-Jun-11, excerpt): >>>>> Hi, >>>>> >>>>> Am 11.06.19 um 15:32 schrieb dt-l...@stefan-klinger.de: >>>>> >>>>>> This option is not about saving disk space, but rather about cleaning >>>>>> up. >>>>> Is the "compress history" button in lighttable view doing anything else? >>>> Woha. I have been talking about "compress history" in darkroom, not >>>> lighttable. >>>> >>>> They seem not to use the same code internally. >>>> >>>> I have to admit that I have not thought about the "compress history" >>>> button in lighttable. That one already seems to remove switched-off >>>> modules in current master [1]. And it seems to do this incorrectly >>>> wrt. parafin's email: >>>> >>>> * In darkroom, disable "white balance" and/or "highlight >>>> reconstruction". >>>> >>>> * Go to lighttable, select that image, and apply "history stack → >>>> compress history" >>>> >>>> * When you open the image again, "white balance" and "highlight >>>> reconstruction" will be enabled again. >>>> >>>> So if compressing should not change the image, then my current >>>> implementation [2] is even more correct, although it only is >>>> applicable from darkroom, not lighttable. >>>> >>>> Cheers >>>> Stefan >>>> >>>> ____________________ >>>> [1] 2.7.0+1443~g9bfbb225e >>>> [2] >>>> https://github.com/darktable-org/darktable/compare/master...s5k6:compressHistory >>>> >>>> >>>> -- >>>> http://stefan-klinger.de o/X >>>> I prefer receiving plain text messages, not exceeding 32kB. /\/ >>>> \ >>>> ___________________________________________________________________________ >>>> darktable developer mailing list >>>> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org >>>> >>> >>> ___________________________________________________________________________ >>> darktable developer mailing list to unsubscribe send a mail to >>> darktable-dev+unsubscr...@lists.darktable.org >> >> ___________________________________________________________________________ >> darktable developer mailing list to unsubscribe send a mail to >> darktable-dev+unsubscr...@lists.darktable.org > > ___________________________________________________________________________ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
