Edgardo Hoszowski (2019-Jun-12, excerpt): > > Edgardo Hoszowski (2019-Jun-11, excerpt): > > > I usually want to keep the (off) modules when compressing history, > > > so the current behavior should be kept. > > > > My implementation already takes care about all these exceptional > > modules I'm aware of: parafin has pointed out "highlight > > reconstruction" and "white balance". There's also "orientation" which > > internally seems to be done by the same module as "highlight > > reconstruction". > > My point is that you should use the setting instead of hard-codding the > modules.
Hmmm. I'm not sure I understand. Are you saying that it schould be a configuration option which modules to remove when disabled? This would add quite some complexity. In order to entirely delete one individual module from the history stack, I'd rather slightly extend the "multiple instances → delete" menu item the IOPs. It does exactly that for non-last instances. This menu item is inactive if it's the last instance (although that is buggy as well), but could easily be extended to just remove this module's entries from the stack. Also, remember that the exemption to not delete some particular modules when they are disabled is a work-around for the questionable decision to not include these modules in the history stack, although active, and although they can be disabled. If this inconsistency is resolved, there would not need to be such an exception. -- http://stefan-klinger.de o/X I prefer receiving plain text messages, not exceeding 32kB. /\/ \ ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
