I've extended darktable.gui.libs.filter and added the sort, sort order,
rating, and rating comparator gui elements.
I've also extended darktable.gui.libs.lighttable_mode and added layout and
zoom level.
Each of these works in the following manner:
If you call them without an argument, i.e.
darktable.gui.libs.filter.sort(), then the current value is returned.
If you call them with an argument, i.e.
darktable.gui.libs.filter.sort("DT_COLLECTION_SORT_DATETIME), then the
change is made and nothing is returned.
My question is this. Is the above acceptable or should I always return the
previous value? If I didn't supply an argument, then it would just be the
current value.
My thought process is that I would query the elements and get the current
configuration. I would change what I needed to get to the desired
configuration, then when I was done I would restore the items I changed to
set it back.
The alternative process is that I change everything to be what I need,
saving the previous values, then restore everything at the end.
Thoughts?
Thanks,
Bill
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
