Hi,
currently I am testing some static code analysis tools to search
systematically for bugs and code smells in the darktable code base. So
far, I found a lot of minor issues, which can be easily fixed, and even
more false positives.
In clipping.c, there is an issue that I am not able to fix. The
following if-then-else statement has identical code in both branches:
else if(p->k_type == 0)
{
d->all_off = 1;
d->k_apply = 0;
}
else
{
d->all_off = 1;
d->k_apply = 0;
}
Either the if-statement in redundant or there is an error in one of the
two branches.
Any suggestion how to fix?
Heiko
--
-- Number Crunch Blog @ https://www.numbercrunch.de
-- Cluster Computing @ https://www.clustercomputing.de
-- Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
