Hi Johannes,
Am 05.09.2018 um 12:08 schrieb johannes hanika:
as to your question, integrate gmic or reimplement. does it make much
of a difference?
main differences:
* using libgmic introduces an additional dependency.
* libgimic is written in C++, GMIC module needs to be implemented in C++.
can the code run on cropped regions of interest and
in floating point? does it work for preview, i.e. does a downscaled
image look similar when processed to first processing and then
downscaling?
For the sharpening filters: At the moment one has to scale the preview
to the scale of the intended export to get an reliable preview. Taking
into account the scaling of the preview and scaling the parameters
accordingly would be easy. However, I am unsure, if applying the
sharpening filters with scaled parameters really gives a better preview.
When it comes to sharpening, I think one always has to zoom in to
adjust the parameter appropriately. Therefore I neglected this issue so
far.
any performance concerns in the interface (need to copy
buffers etc)?
GMIC stores image data quite differently than darktable. Thus
additional copying steps are needed, which is not that so nice.
for R/L sharpening, maybe that would be a popular addition to the
current sharpen module (so it'll be easy to discover)?
Completely agree.
Heiko
--
-- Number Crunch Blog @ https://www.numbercrunch.de
-- Cluster Computing @ https://www.clustercomputing.de
-- Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
