On Wed, Nov 29, 2017 at 6:19 PM, Robert Bieber <d...@biebersprojects.com> wrote: > On 11/29/2017 02:13 AM, Roman Lebedev wrote: >> >> and RawSpeed is LGPL2. so that not is even an option. > > Ahh, good point. >>> >>> 1. Will any of those curve_tools functions in DT do what the cubic_spline >>> function in dcraw (reproduced below for reference) does? I'm not really >>> familiar with calculating curves, but I'm a bit worried that it seems >>> like >>> they're all geared towards interpolating a single point on a curve, which >>> I'm assuming would be very slow compared to the approach dcraw takes of >>> calculating all the points on the curve and then just doing a lookup for >>> each pixel. >> >> Let's not do premature optimizations :) >> Implement the most dumbest/simplest variant, that is actually readable, >> then i'll add tests and a benchmark; and *then* a specialized, faster >> implementation *may* be added. > > > So I should implement cubic spline from scratch? I'll have a go at it, > what's the worst that could go wrong? ;) Well, to put it another way, that dcraw cubic_spline() is just plain hideous. I don't feel like merging it as-is just so that i will have to remplement it soon after.
> Thanks, > Robby > > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
