Am Freitag, 22. September 2017, 13:40:09 CEST schrieb Heiko Bauke: > Hi, > > Am 22.09.2017 um 10:15 schrieb Tobias Ellinghaus: > > IIRC there was some problem with obscure alternate libc implementations > > that had too little stack size or something like that. > > yes, something like that: > https://www.securecoding.cert.org/confluence/display/c/ARR32-C.+Ensure+size+ > arguments+for+variable+length+arrays+are+in+a+valid+range > > Nevertheless, I think one should remove the pragmas from the source > code. Passing the option -Wvla to the compiler should be sufficient.
No, you are missing the point of those pragmas: darktable from git always builds with "-Werror", thus the "-Wvla" switch actually throws an hard error when using VLAs. With the pragma we are relaxing that back to a warning again to be able to use VLAs in some places. > Heiko Tobias
signature.asc
Description: This is a digitally signed message part.
