Am 22.06.2017 um 19:31 schrieb Dan Torop:
Ulrich Pegelow <ulrich.pege...@tongareva.de> writes:
Oh no! I was thinking of the dt_iop_clip_and_zoom_demosaic_{half,third}_*()
functions in imageop_math.c. Those don't have OpenCL implementations, though?
Certainly getting into revising OpenCL code would be a way more invasive effort.
Well there are:
demosaic_vng.cl:clip_and_zoom_demosaic_third_size_xtrans()
demosaic_ppg.cl:clip_and_zoom_demosaic_half_size()
Oh no indeed! I haven't touched the floating point variants, and utterly failed
to note this.
I've only been working on the non-float versions. These at least have no OpenCL
equivalents, yes? They are only called from _init_f() in mipmap_cache.c for
previews (which then never pass through the float downscale), as these are now
downscaled while still mosaiced (which, alas, results in artifacts, but allows
for processing mosaiced data through the pre-demosaic stages of the pipeline).
OK, that sounds good. There should not be any OpenCL code dealing with
non-floating point values at that place. But let me double-check that.
Ulrich
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
