On Thu, Sep 15, 2016 at 9:43 AM, Terry Duell <tdu...@iinet.net.au> wrote: > Hello All, > I have been locally building darktable for some time, using Fedora's > rpmbuild system. > I did a "git pull" only a short while ago and prepared a src archive as I > usually do, and modified my rpmbuild .spec file accordingly. > It built without error and runs OK, but the version string is not displayed > in the "About darktable" window. > I don't believe I have done anything different to what I have been doing for > months, so guess something has changed in the src to cause this. > Following are snippets of my rpmbuild .spec file, and the contents of > "version_gen.h", if it helps, along with a screenshot of the "About > darktable" window. It is version_gen.c now. See https://github.com/darktable-org/darktable/commit/b5c5c1ca02bd01b38c02267e5c436f76d857be2b
You should really use https://github.com/darktable-org/darktable/blob/master/tools/create_version_c.sh instead of guessing how it is done by us. > rpmbuild .spec file (snippets) > ------------------------------ > > Summary: darktable > Name: darktable > Version: 2.1.0 > Release: 0.7.20160915%{?dist} > . > . > . > echo \#define PACKAGE_VERSION \"%{name}-%{version}-%{release}\" >> >> src/version_gen.h > > . > . > . > mkdir build && cd build > %cmake \ > -Wno-dev \ > -DCMAKE_INSTALL_PREFIX=%{_prefix} \ > -DLIB_INSTALL=%{_lib} \ > -DUSE_XMLLINT=OFF \ > -DUSE_SQUISH=OFF \ > -DCMAKE_BUILD_TYPE:STRING=Release \ > -DPROJECT_VERSION:STRING="%{name}-%{version}-%{release}" \ > -DBINARY_PACKAGE_BUILD=1 \ > -DBUILD_CMSTEST=On \ > -DUSE_OPENCL=On \ > .. > > rpmbuild BUILD/darktable-2.1.0/scr/version_gen.h > ------------------------------------------------- > #define PACKAGE_VERSION "darktable-2.1.0-0.7.20160915.fc24" > > Cheers, > -- > Regards, > Terry Duell Roman. > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
