On Fri, Jan 29, 2016 at 9:56 AM, Ulrich Pegelow
<[email protected]> wrote:
> However, for the user I need to give reasonable names to the module
> parameters. I could use internal labels like "a" and "b" and let the user
> figure out what direction this is currently related to. But it would be
> better to have labels that say "horizontal" and "vertical". If I could
> retrieve the orientation relative to the input image in gui_update() I could
> put reasonable labels to the module's sliders.

Won't the names also be wrong if other modules are used? Things like
rotating the image for example. I'm guessing the best complete way of
doing this would be to use the backtransform() that's already in all
the iops to figure out where currently a given point in the camera
coordinate space is being displayed on the screen. That would make it
future proof instead of special casing all the iops that can change
orientation now and in the future. It may be tricky to choose a good
point though as things like crops and warps can make the point move
somewhat wildly. But maybe if it works 90% of the time it's already
better and "a"/"b".

Cheers,

Pedro
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to [email protected]

Reply via email to