HAHA now I see what's going on...
your script cleans up <darktable>/BUILD instead of <darktable>/build. This means that your builds were "poluted" by the results of your previous builds. In particular, the version script's result were carried over from your old build. That explains why it worked when it shouldn't... Now... how are you supposed to make it work... The problem is that copying a git tree in the way you do it is not really safe. There is a specialized git command that is meant to do that for you instead of cp -r * ../$PACK you should do git archive --format=tar --prefix=$PACK HEAD | (cd .. && tar xf -) That should copy DT in a "smart way" * the DT dev can mark some files as not meant to go int srcpkg, this command will not copy those * the .git subdirectory (which is rather big) is not copied, your script didn't remove that * the version information will be correctly generated with the real version information * any local modification you have lying around will not be carried to your srcpkg. Git is actually providing HEAD not your local copy you can probably improve this a bit by replacing HEAD above with the name of a DT tag, feel free to test... hope this helps. Feel free to post an updated version of your script if you want me to help with an update version... On Wed, Oct 14, 2015 at 11:41 PM, Terry Duell <tdu...@iinet.net.au> wrote: > Hello Jeremy, > > On Thu, 15 Oct 2015 00:39:34 +1100, jeremy rosen < > jeremy.ro...@enst-bretagne.fr> wrote: > > that's... less suprising but still not correct. Are you building in a >> proper git repository, or is it some form of copy of the git repository >> (I have no idea of how a fedora package is built) >> >> this message is supposed to appear if git is not available or if your >> source code is not in a git repository (more precisely, if 'git describe' >> reports nothing) >> >> could you test if that's the case for you ? >> >> > OK, I'm building in a copy of a git repo, and probably not doing that > correctly, although it has been working OK, in regard to the project > version and "About darktable" message until recently. > I build my Fedora packages using Fedora's rpmbuild, which uses a .spec > file to define the process. > The source is an archive (tar.gz, tar.bz2 etc). > I always build a src.rpm as well as a binary (rpm) package. The src.rpm > contains the src archive and the .spec file and is a convenient way of > rebuilding the binary package later or elsewhere. > Hence, it is convenient to use a minimal source archive and I strip out > the docs and other files I don't need. > The .spec file calls cmake and controls the build process. > To clarify I have attached the simple script I run to generate the source > archive used for the rpmbuild process. > Is there a better way of doing this that is compatible with the current > way of defining the project version? > > > Cheers, > -- > Regards, > Terry Duell > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
