On Mon, Jun 29, 2009 at 11:53:22AM +0200, Corinna Vinschen wrote: >On Jun 29 11:28, Corinna Vinschen wrote: >>On Jun 28 15:31, Christopher Faylor wrote: >>>Btw, Corinna, were you proposing turning the "FIXME" code in peek_pipe >>>back on? >> >>I'm a bit wary to do that, but... >> >>>I don't think I ever saw it fail myself after my last round of tweaks >>>but I don't remember what the exact problem was. Did it fail on some >>>version of Windows NT/2000/XP/2003/2008/7? >> >>...I just searched for the old threads and here's where the problem >>starts: http://cygwin.com/ml/cygwin/2004-09/msg00416.html >> >>That led to: http://cygwin.com/ml/cygwin-patches/2004-q3/msg00091.html >> >>And then there was the Unison problem: >>http://cygwin.com/ml/cygwin/2004-09/msg01131.html >> >>Which was subsequently discussed here: >>http://cygwin.com/ml/cygwin-patches/2004-q3/msg00133.html >> >>I tested sftp with big files (Gigs) and it appears to work fine with >>the FIXME code switched back to life. I tested the unison command >>using Cygwin's unison 2.31.4-2 under tcsh and it worked fine. I tested >>various combinations with pipes created by a native application and >>with native applications on send and receive side of a Cygwin pipe and >>all my testcases worked as expected. >> >>So, maybe we should really give it a try again. > >Btw., I also tried the rsync of 9000 files with the FIXME code active >and it worked a couple of times in a row without fail.
I did make a change subsequent to your turning off this code. Maybe that was enough to get things working. Either that or, if you are using the trunk code, maybe you aren't hitting this at all anymore since there are overlapped I/O accomodations. Anyway, I wouldn't mind giving the code another try if you are up for it. Although I didn't write the code originally, it has always bothered me that it didn't work because it seems like it should have. Shall I turn it on, create a snapshot, and then ask our legion of testers to try it? cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
