Larry Hall (Cygwin) wrote:
Larry Hall (Cygwin) wrote:
Christopher Faylor wrote:
On Thu, Jan 05, 2006 at 09:34:07PM -0500, Christopher Faylor wrote:
That was supposed to fix the problem of console windows appearing
when the
service is allowed to interact with the desktop.
Does this do anything, Larry?
cgf
Index: fhandler_console.cc
===================================================================
RCS file: /cvs/uberbaum/winsup/cygwin/fhandler_console.cc,v
retrieving revision 1.155
diff -u -p -r1.155 fhandler_console.cc
--- fhandler_console.cc 5 Jan 2006 16:26:22 -0000 1.155
+++ fhandler_console.cc 6 Jan 2006 02:54:56 -0000
@@ -146,7 +146,7 @@ tty_list::get_tty (int n)
void __stdcall
set_console_state_for_spawn (bool noncygwin_process)
{
- if (noncygwin_process && fhandler_console::need_invisible ())
+ if ((1 || noncygwin_process) && fhandler_console::need_invisible ())
return;
OK, stupid question but why do we want this part? For me, reverting this
change allows me to start sshd and get output from 'ssh localhost date'.
I guess I should be trying to reproduce the console window problem to
answer the above...
Yeah, stupid question. Never mind. I see... But wait, now it all seems
to work. I guess this means that your patch Chris is a (confusing)
success.
I'll bang on it a bit more to see if I can convince myself I didn't see
the ssh output failure the first time around...
Chris, you asleep? Good. No need to disturb a good night's sleep with
some bad news.
I figured out why it didn't work for me the first time and why it did
after that. I think I'm finally up-to-speed with what these two competing
blocks of code do to create this issue. ;-) For all those wondering (does
anybody still have the strength to keep reading this thread? ;-) ), the
first time I tried it, sshd could not interact with the desktop. With
Chris's patch and this switch off, I see no extra consoles and no output
from 'ssh localhost date'. Turning on desktop interaction for sshd and
restarting the service, I see no extra consoles and I get output from
'ssh localhost date'. It's all so obvious now. ;-)
So there is still a problem (but a less than appetizing workaround).
--
Larry Hall http://www.rfk.com
RFK Partners, Inc. (508) 893-9779 - RFK Office
838 Washington Street (508) 893-9889 - FAX
Holliston, MA 01746
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
