On Jan 18 07:02, Eric Blake wrote: > Corinna, why did you change od in coreutils 5.2.1? When I proposed your > patch upstream, the maintainers pointed out that 12 lines later in the > same method, the code is calling setmode(fd, O_BINARY) for all non-tty > input filenames that were just fopen'd. Does cygwin have a working > setmode (and if not, does fcntl(fd, F_SETFL, O_BINARY | fcntl(fd, > F_GETFL)) work as expected)?
He's of course right. Just keep the patch in as a Cygwin local patch which shouldn't go upstream. What happened was that od failed to read files in binary mode on textmode mounts. It turned out that recent Cygwin/newlib changes resulted in setmode only working correctly on the stdio descriptors 0, 1 and 2. This is fixed in CVS, but the problem persists in 1.5.12. The patch circumvents that problem in 1.5.12, but it will become unnecessary later on. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader mailto:cygwin@cygwin.com Red Hat, Inc. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
