Re: [PATCH] Fix for broken package-grep.cgi (Attn: CGF)

[Igor Pechtchanski]

On Wed, 28 Jan 2004, Christopher Faylor wrote:

> On Wed, Jan 28, 2004 at 07:38:26PM -0500, Igor Pechtchanski wrote:
> [snip]
> >ChangeLog:
> >2004-01-28  Igor Pechtchanski  <[EMAIL PROTECTED]>
> >
> >       * package-grep.cgi (findheader): Quote raw filename in pattern.
>
> Please check in.
> Thanks,
> cgf

Whoops, this was missing another piece.  The files with '+'s are now
properly displayed, but the links to the contents are screwed up, due to
'+' being translated into ' ' by the URL encoding/decoding.  Something
like

Index: package-grep.cgi
===================================================================
RCS file: /cvs/cygwin/htdocs/cgi-bin2/package-grep.cgi,v
retrieving revision 1.27
diff -u -p -r1.27 package-grep.cgi
--- package-grep.cgi    29 Jan 2004 02:32:47 -0000      1.27
+++ package-grep.cgi    29 Jan 2004 02:52:59 -0000
@@ -49,7 +49,7 @@ if (%main::packages) {
     for my $p (sort keys %main::packages) {
        for my $f (@{$main::packages{$p}}) {
            print '<tr><td><img src="http://sources.redhat.com/icons/ball.gray.gif"; 
height=10 width=10 alt=""></td>',
-                  "<td cellspacing=10><a href=\"package-cat.cgi?file=$f&grep=" . 
uri_escape($grep) . '">' . $f . '</a></td><td align="left">' . findheader($p, $index) 
. "</td></tr>\n";
+                  "<td cellspacing=10><a href=\"package-cat.cgi?file=" . 
uri_escape($f) . "&grep=" . uri_escape($grep) . '">' . $f . '</a></td><td 
align="left">' . findheader($p, $index) . "</td></tr>\n";
        }
     }
 }

should fix it.
        Igor
-- 
                                http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_                [EMAIL PROTECTED]
ZZZzz /,`.-'`'    -.  ;-;;,_            [EMAIL PROTECTED]
     |,4-  ) )-,_. ,\ (  `'-'           Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL     a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/