( replying to the wrong mail-in-thread )
( because missed the original posting )
On Tue, 10 Jun 2003, Ronald Landheer-Cieslak wrote:
> > Index: cron.c
> > ===================================================================
> > RCS file: /home/cvs/cvsroot/src/cron/cron.c,v
> > retrieving revision 1.5
> > diff -p -u -r1.5 cron.c
> > --- cron.c 11 Apr 2003 19:42:37 -0000 1.5
> > +++ cron.c 6 Jun 2003 07:13:17 -0000
> > @@ -26,6 +26,7 @@ static const char rcsid[] = "$Id: cron.c
> > #include "cron.h"
> > #ifdef __CYGWIN__
> > #include <signal.h>
> > +#include <sys/fcntl.h>
> > #else
> > #include <sys/signal.h>
> > #endif
> > @@ -115,6 +116,21 @@ main(argc, argv)
> > }
> >
> > acquire_daemonlock(0);
> > +
> > +#ifdef __CYGWIN__
> > + {
> > + int fd;
> > + if ((fd = open("/dev/null", O_RDWR, 0)) != -1)
> > + {
> > + (void)dup2(fd, STDIN_FILENO);
> > + (void)dup2(fd, STDOUT_FILENO);
> > + (void)dup2(fd, STDERR_FILENO);
> > + if (fd > 2)
> > + (void)close (fd);
Should not this read :
if ( (fd != STDIN_FILENO) && (fd != STDOUT_FILENO) & .. )
If you already use symbolic constants for the file descriptors?
Just imagine a weird system, having e.g. STDOUT_FILENO defined
as 3. (I doubt, something like that exist, but who knows?)
> > + }
> > + }
> > +#endif
> > +
> > database.head = NULL;
Bjoern
P.S.: No nothing bad intended, it just looks - hmm - unusual.
--
+---------------------------------------------------------------------+
| Dipl.-Phys. Bjoern Kahl +++ AG Embedded Systems and Robotics (RESY) |
| Informatics Faculty +++ Building 48 +++ University of Kaiserslautern|
| phone: +49-631-205-2654 +++ www: http://resy.informatik.uni-kl.de |
+---------------------------------------------------------------------+
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
