Please keep the discussion on the mailing list. On 12/18/2024 4:55 PM, matthew patton wrote:
PLEASE put in a comment that the else case is testing the 'u_addr = addr' and that u_addr < addr is not possible given the logic in match. I HATE code that requires you to go digging around in multiple places and step thru other methods in order to glean what the current method's assumptions are predicated upon. That's utter shit but extremely common by C coders.
I'm currently working on refactoring match() so that the logic is easier to follow. This will include adding comments, as well as adding a new parameter to match() that allows it to indicate whether or not one region is contained in the other. This won't get done immediately, because I have something more pressing that I want to do first.
Ken -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
