On Jun 24 18:34, Thomas Wolff wrote: > Am 24.06.2018 um 00:32 schrieb Thomas Wolff: > > Am 23.06.2018 um 20:46 schrieb Brian Inglis: > > > On 2018-06-22 17:06, Takashi Yano wrote: > > > > On Sat, 23 Jun 2018 05:39:27 +0900 > > > > Takashi Yano wrote: > > > > > I looked into this problem, and found this is caused by incorrect > > > > > return value of iswprint(). > > > > I have found the cause. That is, file categories.t is not correct. > > > > > > > > For example, > > > > http://ftp.unicode.org/Public/UNIDATA/UnicodeData.txt says: > > > > > > > > 3400;<CJK Ideograph Extension A, First>;Lo;0;L;;;;;N;;;;; > > > > 4DB5;<CJK Ideograph Extension A, Last>;Lo;0;L;;;;;N;;;;; > > > > ... > > > > 4E00;<CJK Ideograph, First>;Lo;0;L;;;;;N;;;;; > > > > 9FEF;<CJK Ideograph, Last>;Lo;0;L;;;;;N;;;;; > > > > > > > > However, categories.t is: > > > > {CAT_Lo, 0x3400, 0}, > > > > {CAT_Lo, 0x4DB5, 0}, > > > > ... > > > > {CAT_Lo, 0x4E00, 0}, > > > > {CAT_Lo, 0x9FEA, 0}, > > > > > > > > Therefore, the script mkcategories which generates categories.t > > > > should be fixed. > > Obviously. I will check why the script was failing here and thanks for > > the patch already. > Yeah, I totally failed to consider the First...Last ranges in this script, > how embarassing. > I would have chosen other markers than 0/1 for the two cases (maybe > "firstlast" for the new one), and not put it in the middle, but you fixed it > anyway; except for the Private Use ranges E000..F8FF, F0000..FFFFD, > 100000..10FFFD, but their category Co isn't used anyway. > I suggest you submit your patch directly to cygwin-patc...@cygwin.com.
In theory this belongs to newlib AT sourceware DOT org since it only affects newlib code, and the non-Cygwin newlib guys would probably like to see these patches as well :) > One > issue, though: > Apparently, you used a Unicode version other than 10.0 as a reference, > probably 11.0. Maybe the fixing patch should be based on the same version, > for better clarity and to reduce the diff (fewer changes in categories.t and > none in caseconv.t). Takashi, does your patch on cygwin-patches take this into account? I think Thomas has a good point here, the generated files should always match a single version. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
signature.asc
Description: PGP signature
