On 02/23/2012 05:53 AM, Earnie Boyd wrote: > On Wed, Feb 22, 2012 at 4:54 PM, Matt Seitz (matseitz) wrote: >> "Eric Blake (cygwin)" wrote: >>> >>> This release should cater to the fact that tcl is now X-based. Before >>> reporting any problems with gitk or git-gui, first check that you are >>> running an X server. Also, gitk will complain if your ~/.gitk has a >>> line 'set uicolor SystemButtonFace'; there's nothing I can do about it >>> at a packaging level, but you can remove the offending line to get >> past it. >> >> Below is a diff of how I fixed the problem in my existing .gitk file. > > While this resolves an immediate issue you should determine the fix > for platform determination in the upstream source so that the correct > file is created in the first place.
The problem only occurs if you have a native-tcl run of gitk that created ~/.gitk, then upgrade git to the X-tcl version, and reload that ~/.gitk. If you only ever used gitk after installing the X-tcl version, the upstream code is doing the correct thing. But yes, an upstream patch that teaches gitk to be tolerant regardless of which style ~/.gitk was previously created in would be appreciated. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
