On 02/09/2010 06:42, Andy Koppe wrote:
On 2 September 2010 05:18, Vasya Pupkin wrote:
I'm trying to compile setup.exe from source code I got from CVS.
Great!
For some reason, I am getting an error:
propsheet.cc: In member function `bool PropSheet::SetActivePage(int)':
propsheet.cc:444: error: expected id-expression before '::' token
propsheet.cc:444: error: expected `)' before '::' token
propsheet.cc:444: error: expected `;' before '::' token
propsheet.cc:444: error: expected `;' before ')' token
propsheet.cc: In member function `bool PropSheet::SetActivePageByID(int)':
propsheet.cc:452: error: expected id-expression before '::' token
propsheet.cc:452: error: expected `)' before '::' token
propsheet.cc:452: error: expected `;' before '::' token
propsheet.cc:452: error: expected `;' before ')' token
propsheet.cc: In member function `void PropSheet::SetButtons(DWORD)':
propsheet.cc:459: error: expected id-expression before '::' token
propsheet.cc:459: error: expected `;' before '::' token
propsheet.cc: In member function `void PropSheet::PressButton(int)':
propsheet.cc:465: error: expected id-expression before '::' token
propsheet.cc:465: error: expected `;' before '::' token
make[2]: *** [propsheet.o] Error 1
I did not touch this file. I installed all required packages and
followed instruction in README file.
Hmm, newly fails for me too, and I can't work out why, given that the
line in question is ancient code. I configured thusly:
./configure -C --disable-shared --host=i686-pc-mingw32
--build=i686-pc-cygwin CC="gcc-3 -mno-cygwin" CXX="g++-3 -mno-cygwin"
This was broken by the recent w32api-3.15 update, which seems to have made
those PropSheet macros C++ aware, so the global scoping operator is no longer
needed.
Patch attached to fix it, but I couldn't work out how to also get it to build
with w32api-3.14.
Index: propsheet.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/propsheet.cc,v
retrieving revision 2.15
diff -u -r2.15 propsheet.cc
--- propsheet.cc 30 Jun 2009 04:14:29 -0000 2.15
+++ propsheet.cc 29 Aug 2010 09:51:13 -0000
@@ -441,7 +441,7 @@
PropSheet::SetActivePage (int i)
{
// Posts a message to the message queue, so this won't block
- return static_cast < bool > (::PropSheet_SetCurSel (GetHWND (), NULL, i));
+ return static_cast < bool > (PropSheet_SetCurSel (GetHWND (), NULL, i));
}
bool
@@ -449,18 +449,18 @@
{
// Posts a message to the message queue, so this won't block
return static_cast < bool >
- (::PropSheet_SetCurSelByID (GetHWND (), resource_id));
+ (PropSheet_SetCurSelByID (GetHWND (), resource_id));
}
void
PropSheet::SetButtons (DWORD flags)
{
// Posts a message to the message queue, so this won't block
- ::PropSheet_SetWizButtons (GetHWND (), flags);
+ PropSheet_SetWizButtons (GetHWND (), flags);
}
void
PropSheet::PressButton (int button)
{
- ::PropSheet_PressButton (GetHWND (), button);
+ PropSheet_PressButton (GetHWND (), button);
}
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
