On Dec 9 11:48, Andy Koppe wrote: > 2009/12/9 Thomas Wolff: > > So the #define IGN should go as well... > > Yep. > > > Actually, I don't really understand this code part: > > * What is the purpose of the lookup table for the switch rather than just > > switching on a few special control characters? > > Good question. > > > * What is the idea of (randomly?) assigning ERR to some control characters > > and NOR to others? > > I wondered about that too. > > > * How does the case NOR *work* actually? > > Due to the code around line 1530 for dealing with multibyte chars. > Further deepens the mystery regarding the ERR/NOR distinction though. > Do only certain control chars (if any) appear in doublebyte encodings? > > > Maybe after clarifying this, the whole snipplet should be cleaned up a > > little bit. > > Sounds like a good addition to your console patch.
I'd rather have multiple smaller patches which change stuff independently of each other. One big patch with multiple motley changes is quite hard to examine. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
