Wednesday, May 22, 2002, 2:34:47 PM, you wrote:
PT> I can confirm this - here is the output shown from Dr. Mingw JIT:
I'm not sure this is the same crash but the crash I'm reporting is
easy reproducable and I think it is not the expected behaviour :)
Here is more info on it..
The crash is caused by this code from IniParseFindVisitor.cc, line 62:
/* Copy leading part of path to temporary buffer and unescape it */
String prefix (&basePath.cstr_oneuse()[baseLength + 1]);
String mirror = rfc1738_unescape_part (prefix.substr(0,prefix.size() - 1));
baseLenght - the length of the fullpath to the local package dir
basePath - the full path of a directory we are currently scanning
with FindFirstFile and friends.
When scannin the local package directory itself prefix would be with
zero length. Now prefix.size() will result in 0 thus this call
prefix.substr(0,prefix.size() - 1) will look like this
prefix.substr(0, -1) i.e. give me the whole string. Ok fine...
Now take a look at String::substr:
String
String::substr(size_t start, size_t len) const
{
// Adapt the C++ string class
return string(cstr_oneuse()).substr(start, len);
}
Ok cstr_oneuse() would return 0. This is where the crash happens
because the string class does strlen() when this constructor is used
i.e. const char *. I suggest to change this to:
string tmpStr;
tmpStr.assign (cstr_oneuse(), theData->length); // this construct is safe
return tmpStr.substr (start, len);
You can also check theData->length and return empty string :)
Here is a backtrace from the crash:
#0 0x0043a1a5 in String::substr (this=0x152fa94, start=0, len=4294967295)
at /usr/include/g++-3/std/straits.h:125
125 { return strlen (s); }
(gdb) bt
#0 0x0043a1a5 in String::substr (this=0x152fa94, start=0, len=4294967295)
at /usr/include/g++-3/std/straits.h:125
#1 0x0041897c in IniParseFindVisitor::visitFile (this=0x152fe14,
basePath=@0x152fc14, theFile=0x152fc44) at IniParseFindVisitor.cc:65
#2 0x0040e89f in Find::accept (this=0x152fe34, aVisitor=@0x152fe14)
at find.cc:71
#3 0x00410f03 in do_local_ini (owner=0x1f0272) at ini.cc:76
#4 0x00411a3b in do_ini_thread (h=0x400000, owner=0x1f0272) at ini.cc:155
#5 0x00411f58 in do_ini_thread_reflector (p=0x4723a8) at ini.cc:222
#6 0x77e602ed in _libwsock32_a_iname ()
(gdb)
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
