On Fri, May 17, 2002 at 06:06:12PM +0200, Lassi A. Tuura wrote:
>I have been reading cygwin code trying to understand it better, hoping
>to contribute to it later. Pretty cool treasure trove of Windows code
>I must say. I have a question on fhandler_disk_file.cc (rev 1.9). In
>fhandler_disk_file::fstat(), line 114 onwards there is this code:
>
> else if (pc->exists ())
> {
> /* Unfortunately, the above open may fail if the file exists, though.
> So we have to care for this case here, too. */
> WIN32_FIND_DATA wfd;
> HANDLE handle;
> buf->st_nlink = 1;
> if (pc->isdir () && pc->isremote ())
> buf->st_nlink = num_entries (pc->get_win32 ());
>
>Should that be `... && ! pc->isremote ())'? At least the code above,
>various ChangeLog and cvs log messages and the message from Corinna
>(http://www.cygwin.com/ml/cygwin-developers/2000-03/msg00091.html)
>suggest so. If so, I'll be happy to whip up a patch.
Yes, I think you're right. I've checked in a patch. Thanks for noticing
this.
cgf
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/
