Hi Radek, On Jul 25 21:40, Radek Barton via Cygwin-patches wrote: > ChangeLog: > > * newlib/libc/include/stdlib.h (abort): Remove (void) parameter > to fix x64 compilation with GCC 15 cross-compiler. > * winsup/configure.ac: Fix --with-cross-bootstrap flag semantics, > change target_cpu to build_cpu for MinGW toolchain detection, > and conditionally check BFD libraries only when not bootstrapping > to avoid "configure: error: link tests are not allowed after > AC_NO_EXECUTABLES" error. > * winsup/doc/faq-programming.xml: Fix spacing in documentation > for --without-cross-bootstrap flag. > * winsup/testsuite/Makefile.am: Make mingw/cygload test conditional > on CROSS_BOOTSTRAP, use EXEEXT variable for Unix based > cross-compilation > environments that are not adding the extension automatically, use > dynamic busybox path detection instead of hardcoded paths. > * winsup/testsuite/cygrun.sh: Add .exe extension to executable > references for proper cross-platform compatibility. This still have > two > caveats, it assumes cygdrop and cygpath to be present in the > environment. This is becase cygdrop is not part of the newlib-cygwin > repository and using cygpath built from the repository is failing with > "Warning! Stack base is 0x600000. padding ends at 0x5ff7c8. > Delta is 2104. Stack variables could be overwritten!" even for native > x64 environments.
Apart from Jon's points, a small style issue: We shouldn't fall back to the old CVS ChangeLog format for describing things we did. I see how this comes in handy here, but that's very likely just a result of having merged different issues into a single patch. If you split this up, the normal commit summary and text should very likely explain nicely what you did. Thanks, Corinna
