typo in the subject line: locl -> lock
On Jul 21 22:46, Takashi Yano wrote: > ...so that cygheap can be locked/unlocked from outside of mm/cygheap.cc. > > Reviewed-by: Corinna Vinschen <[email protected]> > Signed-off-by: Takashi Yano <[email protected]> > --- > winsup/cygwin/local_includes/cygheap.h | 2 ++ > winsup/cygwin/mm/cygheap.cc | 22 +++++++++++++++++----- > 2 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/winsup/cygwin/local_includes/cygheap.h > b/winsup/cygwin/local_includes/cygheap.h > index fed87ec2b..aa928bc55 100644 > --- a/winsup/cygwin/local_includes/cygheap.h > +++ b/winsup/cygwin/local_includes/cygheap.h > @@ -541,6 +541,8 @@ struct init_cygheap: public mini_cygheap > threadlist_t *find_tls (int, bool&); > sigset_t compute_sigblkmask (); > void unlock_tls (threadlist_t *t) { if (t) ReleaseMutex (t->mutex); } > + void lock (); > + void unlock (); I'm sorry I didn't see this in my first review, but I have a suggestion: Convert cygheap_protect to a static private init_cygheap member and make lock/unlock inline methods. No reason to have two function calls on the stack. Thanks, Corinna
