On 14/07/2025 14:27, Corinna Vinschen wrote:
On Jul 14 15:22, Corinna Vinschen wrote:
On Jul 10 19:21, Radek Barton via Cygwin-patches wrote:
 From 8bfc01898261e341bbc8abb437e159b6b33a9312 Mon Sep 17 00:00:00 2001
From: Evgeny Karpov <[email protected]>
Date: Fri, 4 Jul 2025 20:20:37 +0200
Subject: [PATCH] Cygwin: malloc_wrapper: port to AArch64
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Implements import_address function by decoding adr AArch64 instructions to get
target address.

Signed-off-by: Evgeny Karpov <[email protected]>
[...]

Pushed.


Thanks,
Corinna

Sigh.  Actually I shouldn't have done that.  While Evgeny is the patch
author, the *attached* patch has you, Radek, in the Signed-off-by, and
that's what I now pushed.

Please make sure that Signed-off-by sticks to the author in the attached
patch as well, not to the person sending the patches to the list, please.

If Radek is going to be adding Signed-off: lines of behalf of his colleagues, maybe this is an appropriate place to ask what he thinks he's attesting to with it?


Corinna,

Maybe the "Before you get started" section in [1] should mention Signed-off: and what we think it means?

If we really want it to be mandatory, I guess I could explore the possibility of a push hook to enforce that?

[1] https://cygwin.com/contrib/dll.html

Reply via email to