On Jul  1 16:42, Jeremy Drake via Cygwin-patches wrote:
> stdin and stdout were alreadly allowed for popen, but implementing
> posix_spawn in terms of spawn would require stderr as well.
> 
> Replace the conveniently-located 4 filler bytes with int __stderr so
> that child_info_spawn doesn't have to grow.
> 
> Introduce a struct for passing additional args to ch_worker.spawn, since
> there are getting to be quite a lot of additional args.
> 
> Signed-off-by: Jeremy Drake <[email protected]>
> ---
>  winsup/cygwin/dcrt0.cc                    |  2 ++
>  winsup/cygwin/local_includes/child_info.h | 16 ++++++++++++---
>  winsup/cygwin/spawn.cc                    | 25 ++++++++++++-----------
>  winsup/cygwin/syscalls.cc                 | 14 ++++++-------
>  4 files changed, 35 insertions(+), 22 deletions(-)

This patch is ok-ish.  I suggested another layout of the
child_info_spawn::worker args in opther mail to this list, maybe you
want to discuss this...

Thanks,
Corinna

Reply via email to