On Fri, 04 Apr 2025 07:27:09 +0200 Johannes Schindelin wrote: > Is Jeremy's guess "if raw_write doesn't need to wait (ie, there's room in the > pipe for the write) it doesn't hit the signal stuff" correct? If so, it would > be good to add that part to the commit message because the commit would > otherwise still be incomplete.
That's not correct. Indeed, raw_write() waits for room in the pipe, however, it does not matter in this case. The probelm occurs at cygwait() which waits for pipe mutex as already mentioned in the commit message. > Also: referring to 7ed9adb356df may be technically correct, but human readers > have a much easier time when that shortened commit OID is accompanied by some > human-readable information, such as the string obtained via `git show > --format=reference` (see <https://git-scm.com/docs/git-show#_pretty_formats>). Do you mean "the commit 7ed9adb356df (Cygwin: pipe: Switch pipe mode to blocking mode by default, 2024-09-05)"? Not just "the commit 7ed9adb356df"? -- Takashi Yano <takashi.y...@nifty.ne.jp>
