Re: [PATCH] Cygwin: setpriority, sched_setparam: add missing process access right

[Corinna Vinschen]

On Nov 29 17:12, Christian Franke wrote:
> Regression, sorry!

Shit happens *shrug*

> Subject: [PATCH] Cygwin: setpriority, sched_setparam: add missing process
>  access right
> 
> set_and_check_winprio() also requires PROCESS_QUERY_LIMITED_INFORMATION.
> 
> Fixes: 153b51ee08ef ("Cygwin: setpriority, sched_setparam: fail if Windows 
> sets a lower priority")
> Signed-off-by: Christian Franke <christian.fra...@t-online.de>
> ---
>  winsup/cygwin/miscfuncs.cc | 2 ++
>  winsup/cygwin/sched.cc     | 4 +++-
>  winsup/cygwin/syscalls.cc  | 5 +++--
>  3 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/winsup/cygwin/miscfuncs.cc b/winsup/cygwin/miscfuncs.cc
> index e3bf35cf7..ebe401b93 100644
> --- a/winsup/cygwin/miscfuncs.cc
> +++ b/winsup/cygwin/miscfuncs.cc
> @@ -190,6 +190,8 @@ bool
>  set_and_check_winprio (HANDLE proc, DWORD prio)
>  {
>    DWORD prev_prio = GetPriorityClass (proc);
> +  if (!prev_prio)
> +    return false;

The commit message doesn't explain this part of the patch.  What does it
fix?


Thanks,
Corinna