On Jan 6 14:38, Jon Turney wrote:
> Since 4e7817498efc, we're just running the tests against the installed
> DLL. We're arranging to put the build directory on the path, but since
> it doesn't contain cygwin1.dll (since it's built with a different name
> and renamed on installation), that doesn't have any effect.
>
> Arrange to place the just-built DLL into a directory which the testsuite
> can place on it's path (while running the test, but not while compiling
> it).
>
> Also fix any remaining references to cygwin0.dll in testsuite,
> documentation and comments.
>
> Fixes: 4e7817498efc ("Cygwin: Makefile: Drop all the "test dll"
> considerations")
> ---
>
> Notes:
> This flips a couple of tests from passing to failing, since they try to
> use system(), which doesn't work, because there is no /usr/bin/bash in
> the Cygwin 'installation' at testsuite/runtime/.
>
> I think perhaps the best solution long-term is to remove all these
> fragile hacks to try to run the testsuite on top of an existing Cygwin,
> and instead the CI should save the result of 'make install' in an
> archive, and a job should unpack that and run the testsuite on it...
>
> winsup/cygwin/Makefile.am | 8 +++++---
> winsup/cygwin/scripts/analyze_sigfe | 2 +-
> winsup/testsuite/Makefile.am | 3 ++-
> winsup/testsuite/README | 9 +++------
> winsup/testsuite/config/default.exp | 2 +-
> winsup/testsuite/winsup.api/cygload.exp | 2 +-
> winsup/testsuite/winsup.api/winsup.exp | 8 +++++---
> 7 files changed, 18 insertions(+), 16 deletions(-)
All your patches to the testsuite are auto-approved.
Just go ahead with whatever you deem right. We can handle any question
on IRC.
Thanks,
Corinna
