On 26/04/2021 16:03, Corinna Vinschen wrote:
On Apr 22 13:57, Corinna Vinschen wrote:
On Apr 21 18:40, Corinna Vinschen wrote:
On Apr 20 21:15, Jon Turney wrote:
On 20/04/2021 21:13, Jon Turney wrote:
* some object files are in a unexpected places in the build file hierarchy
(compared to naive expectations and/or the non-automake build)
This is the only minor qualm I have with this patch. It would be nice
to have the mingw sources and .o files in the mingw subdir. It would
simply be a bit cleaner. The files shared between cygwin and mingw
(that's only path.cc, I think) could be handled by an include, i. e.
utils/
path.cc (full implementation)
utils/mingw/
path.cc:
#include "../path.cc"
I wonder if it wouldn't make sense to split out the mingw-only parts
of path.cc entirely. I had a quick view into the file and it turns
out that of the almost 1000 lines in this file, only about 100 lines
are used by mount. All the rest is only used by mingw code, i. e.,
cygcheck and strace.
That's obviously not part of this patch, but something we should keep
in mind for a later cleanup.
I tried this as a POC and it's not much of a problem. See the below
patch. Cleaning up the includes is still to do.
Thanks, this seems workable. I'll take a look.
