Re: [PATCH] Cygwin: console: Prevent NULL pointer access in close().

[Corinna Vinschen via Cygwin-patches]

On Feb 22 22:30, Takashi Yano via Cygwin-patches wrote:
> - There seems to be a case that shared_console_info is not set yet
>   when close() is called. This patch adds guard for such case.
> ---
>  winsup/cygwin/fhandler_console.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/fhandler_console.cc 
> b/winsup/cygwin/fhandler_console.cc
> index 6ded9eabf..96a8729e8 100644
> --- a/winsup/cygwin/fhandler_console.cc
> +++ b/winsup/cygwin/fhandler_console.cc
> @@ -1393,7 +1393,7 @@ fhandler_console::close ()
>  
>    release_output_mutex ();
>  
> -  if (con.owner == myself->pid)
> +  if (shared_console_info && con.owner == myself->pid)
>      {
>        char name[MAX_PATH];
>        shared_name (name, CONS_THREAD_SYNC, get_minor ());
> -- 
> 2.30.0

Pushed.


Thanks,
Corinna