On Dec 8 11:58, Jeremy Drake via Cygwin-patches wrote: > On Tue, 8 Dec 2020, Jon Turney wrote: > > On 07/12/2020 09:43, Corinna Vinschen wrote: > > > On Dec 4 10:35, Jeremy Drake via Cygwin-patches wrote: > > > > On Fri, 4 Dec 2020, Corinna Vinschen via Cygwin-patches wrote: > > > > > > > > > I'm not happy about a new CYGWIN option. > > > > > > > > > > Wouldn't it make sense, perhaps, to switch to > > > > > CREATE_DEFAULT_ERROR_MODE > > > > > for all non-Cygwin processes by default instead? > > > > I agree. > > > > Cygwin calls SetErrorMode(), so we need to use this flag to prevent that > > non-default behaviour being inherited by processes started with > > CreateProcess(). > > > > In that case, here's my initial, much simpler patch > [...] > - c_flags |= CREATE_SEPARATE_WOW_VDM | CREATE_UNICODE_ENVIRONMENT; > + c_flags |= CREATE_SEPARATE_WOW_VDM | CREATE_UNICODE_ENVIRONMENT > + | CREATE_DEFAULT_ERROR_MODE; > [...]
Thanks, but the flag should only be added when starting a non-cygwin process. Checking against real_path.iscygexec() will do the job. Can you please resend this as a standard git format-patch'ed mail? Thanks, Corinna
