On Apr 1 18:36, Jon TURNEY wrote: > On 01/04/2015 15:22, Corinna Vinschen wrote: > >On Apr 1 14:19, Jon TURNEY wrote: > >>Add ucontext.h header, defining ucontext_t and mcontext_t types. > >> > >>Provide sigaction sighandlers with a ucontext_t parameter, containing stack > >>and > >>context information. > >> > >> * include/sys/ucontext.h : New header. > >> * include/ucontext.h : Ditto. > >> * exceptions.cc (call_signal_handler): Provide ucontext_t > >> parameter to signal handler function. > > > >Patch is ok with a single change: Please add a "FIXME?" comment to: > > > > else > > RtlCaptureContext(); > > > >On second thought, calling RtlCaptureContext here is probably wrong. > > > >What we really need is the context of the thread when calling > >call_signal_handler I think. > > I had the same thought, but this is going to be quite tricky to achieve. > > This patch depends on the change to newlib to add stack_t, so I will wait > for that to land before committing this patch.
I ACKed the newlib patch already. You can simply omit the RTEMS and Cygwin checks. Sebastian is right, there's no good reason to guard the definition like this. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
pgpiG7l4_Lthy.pgp
Description: PGP signature
