On Wed, Sep 25, 2013 at 12:41:17PM +0200, Paul Kunysch wrote: >> That looks like a reasonable fix. Did you trace through all of the >> callers of semaphore::_getvalue to make sure that some of them aren't >> relying on the old behavior? > >I did not look for other callers. > >I just wrote a very simple test for sem_getvalue() and copied different >cygwin1.dll versions to my test-application.
I was being too vague here. You made what looks like a reasonable change but it is to a low-level function which is called by more than one place. I was hoping that, since you wanted to see this fixed, you might also be willing to make sure that your change doesn't break anything else. But, I didn't say that so, my bad. I've checked in a modified version of your patch along with a ChangeLog. Thanks. cgf
