On Wed, 19 Mar 2003, Robert Collins wrote:
> I'm happy with changing the method naming format, but is it GNU > standard? Thats a requirement for the cygwin project. > > http://www.gnu.org/prep/standards_26.html#SEC26 says that > "For example, you should use names like ignore_space_change_flag; don't > use names like iCantReadThis." > > Now, I happen to disagree with the GNU conventions here, particularly as > they don't have a C++ section (and C doesn't have the same degree of > name space conflicts that C++ does) :}. But, the pthread code should > stay within the GNU guidelines. > > So, I'm sorry to have you jumping through hoops, but can you please > change your patch so that all new methods use the GNU convention here. > I just followed the already existing method names in thread.h. Methods like forEach, initMutex or isGoodObject were made by you. I would suggest to commit my patch now and do a method renaming and 1==foo to foo==1 cleanup in a second step. Thomas
