On Tue, Feb 26, 2002 at 08:59:45PM -0800, Joshua Daniel Franklin wrote: >Well, except that that loop does away with the whole point--eating the >trailing '$'. Here's another go. I tested it with "$Revision$", >"$Revision:$", "$Revision: $ ", "$Revision: 1.22 $ ", and "$Revision: 1.2 2 $ " >(in the unlikely event of a version number with spaces) and it does the right >thing on each.
There's no need for a loop. There really shouldn't be any need to accommodate the missing colon but it doesn't hurt too much to add a test case. I've checked in a modified version of your patch. I cleaned up some of the non-GNU formatting, added a ChangeLog, and added a "print_version" function which parses the 'version' array for version info. I appreciate the submission very much but, next time, I would also appreciate a ChangeLog and more attention to formatting issues. cgf