On Feb 8 16:07, Jon Turney via Cygwin-apps wrote: > On 07/02/2024 10:46, Corinna Vinschen via Cygwin-apps wrote: > > Also fix ambiguous method declaration by dropping a default parameter. > > --- > > Hi Jon, > > > > I'm not sure removing virtual from all Create methods really fits the > > bill in all cases, are you? > > > > I had a go at fixing this while keeping the virtuality of the methods > > intact. While at it it also occured to me that there's a tricky problem > > for the compiler to differentiate the method > > This seems like overkill. > > From auditing the code, as far as I can tell, we only ever instantiate > PropPage-derived objects for each of the setup wizard pages, and one > PropSheet object to contain them. > > There are no instantiations of the Window class itself. > > PropPage::Create() doesn't even call Window::Create(), so that method can > actually be totally removed without problem...
I just thought it might be a good idea to keep virtuality, but your assessment shows that was unnecessary. No worries from my side. Corinna
